aboutcode-org / scancode-workbench

:bar_chart: ScanCode Workbench is a desktop app to review and conclude license and origin from code scans generated by ScanCode Toolkit.
https://github.com/nexB/scancode-workbench/releases/latest
Apache License 2.0
154 stars 70 forks source link

Add File / Close command #596

Closed mjherzog closed 12 months ago

mjherzog commented 1 year ago

Description

We should add a Close command to the File menu. This command would clear the current Scan data and return you to the Home screen. This would address a current problem for the use case:

This has been a long-standing problem and it is still present for v4.0.0r3. I will retest with v40.0rc4

mjherzog commented 1 year ago

I just tested on v4.0.0rc4 and the new Scan loaded much more quickly than v4.0.0rc3. It still might be a good idea to provide an explicit File Close command.

OmkarPh commented 1 year ago
  • The SCWB display retains the old data in the Table View until after the new file is fully processed which is confusing

Yep, this needs to be resolved

In addition to the menu item (with a shortcut), we should flush the previous scan immediately when the new scan is parsed successfully (If unsuccessful, then keeping the old scan is ok IMO)

mjherzog commented 1 year ago

I suggest the Close command should flush the previous scan immediately - no reason to wait on the results of parsing the new scan. This should be much simpler and the user can always re-open the prior scan if that is what they want to do

AyanSinhaMahapatra commented 1 year ago

I suggest the Close command should flush the previous scan immediately - no reason to wait on the results of parsing the new scan.

Yeah this would be better (unsuccessful parsing should be rare anyway)

OmkarPh commented 1 year ago

what would be an ideal keyboard shortcut for close command? I thought of Ctrl+w but it's already being used to close the window

mjherzog commented 1 year ago

perhaps Ctrl+c

OmkarPh commented 1 year ago

perhaps Ctrl+c

That's reserved for copying :)

OmkarPh commented 12 months ago

Closing as it is implemented and available in v4.0.0 Release