Open AyanSinhaMahapatra opened 1 year ago
We also have this for pypa/gh-action-pypi-publish@master
which needs to be updated to pypa/gh-action-pypi-publish@release/v1
:
You are using "pypa/gh-action-pypi-publish@master". The "master" branch of this project has been sunset and will not receive any updates, not even security bug fixes. Please, make sure to use a supported version. If you want to pin to v1 major version, use "pypa/gh-action-pypi-publish@release/v1". If you feel adventurous, you may opt to use use "pypa/gh-action-pypi-publish@unstable/v1" instead. A more general recommendation is to pin to exact tags or commit shas.
I created the new elf-inspector repo and I am still getting the issue:
Annotations
2 warnings
Create PyPI release: # >> PyPA publish to PyPI GHA: UNSUPPORTED GITHUB ACTION VERSION <<#L1
You are using "pypa/gh-action-pypi-publish@master". The "master" branch of this project has been sunset and will not receive any updates, not even security bug fixes. Please, make sure to use a supported version. If you want to pin to v1 major version, use "pypa/gh-action-pypi-publish@release/v1". If you feel adventurous, you may opt to use use "pypa/gh-action-pypi-publish@unstable/v1" instead. A more general recommendation is to pin to exact tags or commit shas.
Has the the GH action been updated in the skeletton?
Yeah we still have this here: https://github.com/nexB/skeleton/blob/main/.github/workflows/pypi-release.yml#L81
On tests, release scripts and other GitHub actions we see the following warning message now:
From https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/
For us this is:
v3 of https://github.com/actions/checkout/ seems to be upgraded to latest node 16: https://github.com/actions/checkout/compare/v2.4.2...v3.0.2#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5R17-R18
We might want to look at the CHANGELOG too for possible breaking changes too potentially.
I've tested this on my fork of scancode-toolkit with https://github.com/nexB/scancode-toolkit/commit/1448e661ebe5269de666eb069318f1b8bd16cba4: and the doc and release script tests pass allright, here are some links to the actions before and after this update
Before:
After:
There are other github actions we use btw (which we use the latest versions of):