search

aboutcode-org / thirdparty-packages

A collection of various pre-built thirdparty packages with their corresponding source code
0 stars 2 forks source link

Add bitarray 2.7.3 package for Deltacode upgrade #8

Closed arnav-mandal1234 closed 1 year ago

arnav-mandal1234 commented 1 year ago
arnav-mandal1234 commented 1 year ago

@pombredanne @AyanSinhaMahapatra @JonoYang can you please review?

AyanSinhaMahapatra commented 1 year ago

Merging this! Thanks++

AyanSinhaMahapatra commented 1 year ago

@arnav-mandal1234 one small nit for future:

Add references to the issue you are solving in the commit, like this:

Add bitarray 2.7.3 package for Deltacode upgrade #7

Reference: https://github.com/nexB/thirdparty-packages/issues/7
Signed-off-by: Arnav Mandal <arnav.mandal1234@gmail.com>

And also add in the PR description:

Closes/Fixes #7

See https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword

So we have links from the PR to the issue, and this closes automatically after merging!

arnav-mandal1234 commented 1 year ago

@AyanSinhaMahapatra Sure! Will keep these things in mind moving forward. :)