aboutcode-org / typecode

7 stars 9 forks source link

CVE-2007-4559 Patch #29

Closed TrellixVulnTeam closed 1 year ago

TrellixVulnTeam commented 2 years ago

Patching CVE-2007-4559

Hi, we are security researchers from the Advanced Research Center at Trellix. We have began a campaign to patch a widespread bug named CVE-2007-4559. CVE-2007-4559 is a 15 year old bug in the Python tarfile package. By using extract() or extractall() on a tarfile object without sanitizing input, a maliciously crafted .tar file could perform a directory path traversal attack. We found at least one unsantized extractall() in your codebase and are providing a patch for you via pull request. The patch essentially checks to see if all tarfile members will be extracted safely and throws an exception otherwise. We encourage you to use this patch or your own solution to secure against CVE-2007-4559. Further technical information about the vulnerability can be found in this blog.

If you have further questions you may contact us through this projects lead researcher Kasimir Schulz.

pombredanne commented 2 years ago

Thanks...we need a proper DCO signoff from a human to consider this. I am looking at the code in question and whether this is used or not ... AFAICS this is a utility in a vendored copy of pygments that supposed to be used by pygments developers and is fetching and extracting a man page from PHP... we do not use this code. I can accept this patch once DCO'ed but it's mostly harmless. You should suggest a patch in pygments IMHO. Now, if you really want to help here, I would welcome a detailed review of https://github.com/nexB/extractcode core code which are using libarchive and sevenzip.

pombredanne commented 2 years ago

As far as I can see this seems to be generated by a bot :| WTF? ?

pombredanne commented 2 years ago

@TrellixVulnTeam note also that a patch without a test is not acceptable.

pombredanne commented 1 year ago

See also similar spam PR at https://github.com/nexB/python-inspector/pull/111

pombredanne commented 1 year ago

Ok this is total bot-led spam... This will make for a nice blog post IMHO https://github.com/search?q="Patching+CVE-2007-4559"&type=issues