aboutcode-org / vulnerablecode

A free and open vulnerabilities database and the packages they impact. And the tools to aggregate and correlate these vulnerabilities. Sponsored by NLnet https://nlnet.nl/project/vulnerabilitydatabase/ for https://www.aboutcode.org/ Chat at https://gitter.im/aboutcode-org/vulnerablecode Docs at https://vulnerablecode.readthedocs.org/
https://public.vulnerablecode.io
Apache License 2.0
521 stars 190 forks source link

Change label from "Fixed by vulnerabilties" to "Fixes vulnerabilities" #1501

Closed TG1999 closed 1 month ago

TG1999 commented 2 months ago

Screenshot from 2024-07-05 21-31-31

johnmhoran commented 2 months ago

@TG1999 There's no description -- please explain the thinking behind the change you suggest. We've changed the names of these columns several times already in the past -- happy to change again if that what the group wants, but I haven't heard from others that that's what they want.

johnmhoran commented 2 months ago

Not sure if this is helpful, but one way to describe the relationship we're trying to name -- from the PURL's viewpoint, the PURL is "affected by" a vuln or "fixes" a vuln; and from the vuln perspective, the vuln "affects" the PURL or is "fixed by" the PURL. 🤔

mjherzog commented 2 months ago

I think that the current parallel "by" construction makes the most sense.

DennisClark commented 2 months ago

I think that "Fixes vulnerabilities" would be the best solution.

johnmhoran commented 2 months ago

@mjherzog @pombredanne When you have the chance, please share your views on the latest suggestion -- "Fixes vulnerabilities".

mjherzog commented 2 months ago

The terminology is very context dependent as explained by @johnmhoran . So if we are talking about just the Results page context, then changing "Fixed by vulnerabilites" to "Fixes vulnerabilities" make sense. On the Essentials page that changes to:

pombredanne commented 1 month ago

What I see most commonly is "fixed vulnerabilities" from a package point of view, not "fixes vulnerabilities". Juts removing the "by" should be enough

johnmhoran commented 1 month ago

Thanks @pombredanne. I'll make the change you suggest: "Fixed by vulnerabilties" ==> "Fixed vulnerabilities".

pombredanne commented 1 month ago

Closed and merged in the issue https://github.com/nexB/vulnerablecode/issues/1520 that tracks changes in the models, API and UI at once