search

aboutsip / pkts

Pure java based pcap library capable of reading and writing to/from pcaps.
Other
198 stars 92 forks source link

Support for EtherType 802.1Q (VLAN) framing. #102

Closed mbrannstrom closed 5 years ago

mbrannstrom commented 5 years ago

Hi,

I've added support for EtherType 802.1Q (VLAN) framing.

Regards, Mikael Brännström

jonbo372 commented 5 years ago

Great, thank you!

Do you have a unit test for it as well? If you have a raw byte dump you can always do this: https://github.com/aboutsip/pkts/blob/master/pkts-core/src/test/java/io/pkts/RawData.java#L22

mbrannstrom commented 5 years ago

Ok, now there is a unit test as well.

jonbo372 commented 5 years ago

Awesome, thanks!

mbrannstrom commented 5 years ago

Could you make a new release of pkts, e.g. 3.0.4, so I can use this functionality from an official release?

jonbo372 commented 5 years ago

yep, done! Should be available in a few hours, so by the time you wake up (assuming you're in Sweden) it should be available.

mbrannstrom commented 5 years ago

Great!