There is a SipParseException class duplication

aboutsip / pkts

Pure java based pcap library capable of reading and writing to/from pcaps.

Other

198 stars 92 forks source link

There is a SipParseException class duplication #27

Closed jaimecasero closed 7 years ago

jaimecasero commented 9 years ago

apparently there is a duplication coming form different modules: -pkts-core -pkts-sip

I guess the one in core should survive

aboutsip commented 8 years ago

Thanks Jaime, will fix that. My experimental 2.0 branch is complete so I'm going to fix it there and then merge it all after I have fixed all the documentation as well.

aboutsip commented 8 years ago

Hmmm... unfortunately they are not the same. Stupid of me to name them the same thing and under the same package too. They inherit from different base exceptions and also have slightly different intent. I guess one of them has to be renamed/moved.