search

aboutsip / pkts

Pure java based pcap library capable of reading and writing to/from pcaps.
Other
196 stars 91 forks source link

getContentTypeHeader #65

Closed jonbo372 closed 6 years ago

jonbo372 commented 6 years ago

Original https://github.com/aboutsip/sipstack/issues/4

[stormning] After using sipMessage.getContentTypeHeader() , then use sipMessage.toBuffer().toString() I found the contentTypeHeader value is missing

[stormning] io.pkts.packet.sip.header.impl.ContentTypeHeaderImpl#transferValue only transfer params to dst. I modified it as below , and resolved the problem @override protected void transferValue(Buffer dst) { getValue().getBytes(0, dst); super.transferValue(dst); }

jonbo372 commented 6 years ago

Added unit test in the 3.x branch, which shows the bug doesn't exist there. Looking at the fix on @slyak branch it seems that the issue is reported on the very old 1.x branch. Will backport the fix.

Unit test for the 3.x branch: https://github.com/aboutsip/pkts/commit/e59f349fbd64e6e73220d598b2a4b3dd2c3203a3

jonbo372 commented 6 years ago

Fixed in version 1.0.6. Note, this bug does not exist on the 3.x branch.