aboutyou / dart_packages

Dart and Flutter plugins maintained and used by @ABOUTYOU
220 stars 149 forks source link

[sign_in_with_apple] 9 issues when building Flutter app in new Xcode 16.0 #437

Open appcapsergen opened 3 days ago

appcapsergen commented 3 days ago

I have just installed the newly released macOS 15, and with that Xcode 16.0.

Upon trying to (re)build my code, I have noticed that even in the latest version of your sign_in_with_apple package, these 9 issues occur (in full):

Screenshot 2024-09-17 at 7 47 38 PM

This urgently requires your attention, since anybody who upgrades their MacBook is now unable to run or build their Flutter app if they use this package.

0x1306e6d commented 2 days ago

As a workaround, I downgraded Swift Language Version to 5 and it works now for me.

image
appcapsergen commented 1 day ago

As a workaround, I downgraded Swift Language Version to 5 and it works now for me.

@0x1306e6d Thank you for your response, but your workaround does not work for me. Not sure if I'm doing something wrong, what were your steps to solve this exactly?

I will also wait for a response from the sign_in_with_apple team to resolve this for Swift 6.

tp commented 1 day ago

@appcapsergen I have not upgraded macOS yet, for fear of build problems in my actively developed projects.

But I'll see that I get the new Xcode installed side-by-side and then we should see the same "Swift 6" errors as well. Will then check how we can (conditionally) support both.

But as I am currently traveling, I will probably not get to it before the middle of next week.

appcapsergen commented 1 day ago

Thank you for the response and transparency @tp! I will hopefully see the progress in this issue.

0x1306e6d commented 1 day ago

Thank you for your response, but your workaround does not work for me. Not sure if I'm doing something wrong, what were your steps to solve this exactly?

I specified CLANG_ALLOW_NON_MODULAR_INCLUDES_IN_FRAMEWORK_MODULES to YES to address Firebase issue (https://github.com/firebase/flutterfire/issues/13323). Even so, I don't think it is related with this issue.

I will also wait for a response from the sign_in_with_apple team to resolve this for Swift 6.

+1