search

aboveyunhai / chakra-dayzed-datepicker

Chakra UI + Dayzed = datepicker
https://aboveyunhai.github.io/chakra-dayzed-datepicker/
MIT License
222 stars 46 forks source link

Enhance configs Prop in RangeDatepicker to Include monthsToDisplay #66

Closed nt9142 closed 9 months ago

nt9142 commented 10 months ago

This PR introduces a new enhancement to the RangeDatepicker component. With this update, users can now specify the number of months they want to display in the datepicker.

This enhancement allows for greater flexibility when integrating the datepicker into various user interfaces, especially where space or user experience considerations might dictate displaying a different number of months.

Please review and let me know if any further changes are required.

aboveyunhai commented 10 months ago

@nt9142 I got the idea what you are trying to do, there is a typescript error from the PR if you check it locally. Do you want me to fix it for you in this pr or handle it by yourself. And you need to export the props to the datepicker configs level.

nt9142 commented 10 months ago

@aboveyunhai oops, my bad! I made sure the props are exported correctly. Can you give it another look? Thanks!

aboveyunhai commented 9 months ago

@nt9142 lgtm, I also fixed some of my own typescript mistakes (since some of them misguide your code) if you're interested in taking a look.