search

aboveyunhai / chakra-dayzed-datepicker

Chakra UI + Dayzed = datepicker
https://aboveyunhai.github.io/chakra-dayzed-datepicker/
MIT License
222 stars 46 forks source link

Allow selected styling while being disabled #77

Closed namolnad closed 3 months ago

namolnad commented 3 months ago

As part of #76, this PR proposes to allow the selectedBtnProps even if a given dayOfMonth is disabled (e.g. being below minDate). The element remains disabled, both functionally and visually, yet allows the component to indicate that there is indeed a selected date (and/or likely range) that exists outside of the currently selectable/valid range. An example of what this looks like is shown here: Screenshot 2024-03-22 at 4 14 38 PM

I'd imagine this is closer to expected behavior, so don't think it's necessarily required to add additional props to allow this behavior sometimes, but am certainly open to that if you disagree.

Thanks for considering!

namolnad commented 3 months ago

@aboveyunhai I just wanted to check in on this to see if you had thoughts about this PR and whether it may be worth moving forward. Thanks!

aboveyunhai commented 3 months ago

@aboveyunhai I just wanted to check in on this to see if you had thoughts about this PR and whether it may be worth moving forward. Thanks!

I think it's fine. I will just merge it and see if ppl complaint about it, if so then turn into optional or something.