search

abp-filters / abp-filters-anti-cv

GNU General Public License v3.0
176 stars 62 forks source link

gismeteo.ua #162

Closed dimisa-RUAdList closed 5 years ago

dimisa-RUAdList commented 5 years ago

Please add a snippet: gismeteo.ua#$#abort-current-inline-script document.createElement

https://www.gismeteo.ua/

https://i.imgur.com/TaE3jVb.jpg

wizmak commented 5 years ago

Please add a snippet: gismeteo.ua#$#abort-current-inline-script document.createElement

@dimisa-RUAdList Doesn't seem to work, can you check again?

dimisa-RUAdList commented 5 years ago

Indeed. This site works very unstable for me. Try it: gismeteo.ua#$#abort-on-property-read localStorage

wizmak commented 5 years ago

gismeteo.ua#$#abort-on-property-read localStorage

@dimisa-RUAdList also not working for me.

dimisa-RUAdList commented 5 years ago

For me it works fine.

dimisa-RUAdList commented 5 years ago

https://imgur.com/a/xVnwIT1

wizmak commented 5 years ago

@dimisa-RUAdList For me It works only if I add/enable the filter before opening the website.

dimisa-RUAdList commented 5 years ago

May be: gismeteo.ua#$#abort-on-property-read localStorage; abort-on-property-write document.cookie

dimisa-RUAdList commented 5 years ago

Please add a snippet: gismeteo.ua#$#abort-on-property-read Object

DukeBG commented 5 years ago

Hi

Just spent half an hour trying to figure out, why gismeteo.ua stopped working correctly today. Tracked it down to this issue.

abort-on-property-read Object breaks jQuery which is used for tabs widget. To switch between three days of the week. And probably other functionality in the website.

They have both the fuctionality of the website and some "FuckAdBlock 3.2.1" functionality in the same script bundle right now //s1.gismeteo.ua/static/compressed/origin_afdd08dd.js

Please remove abort-on-property-read Object. Breaking the website is not a good way to switch off ads.

wizmak commented 5 years ago

Hi @DukeBG thank you for your report, problematic filter is now removed.

dimisa-RUAdList commented 5 years ago

I believe that deleting a rule without replacing - is a bad decision.

mapx- commented 5 years ago

Does this break something ? gismeteo.ua#$#abort-on-property-read loadMain

DukeBG commented 5 years ago

No, but it also doesn't remove the ads.

Edit: ah, nevermin, together with abort-on-property-read localStorage and abort-on-property-write document.cookie it does. Looks like a solution

mapx- commented 5 years ago

no needing on my side, only (the last 3 filters are from russian adguard)

gismeteo.ua#$#abort-on-property-read loadMain
gismeteo.ua##div[id="weather-rbkua"]
gismeteo.ua##div#weather-right[id="weather-right"]
gismeteo.ua##.wrap > div#w-hor
dimisa-RUAdList commented 5 years ago

gismeteo.ua#$#abort-on-property-read localStorage; abort-on-property-write document.cookie; abort-on-property-read loadMain - it works well

wizmak commented 5 years ago

@mapx-

gismeteo.ua#$#abort-on-property-read loadMain

This filter alone works well for me, no need for extra filters at the moment.

DukeBG commented 5 years ago

Worked for me too. Not exactly sure why it didn't work previously.

Reading their js code, I'm a bit conflicted about document.cookie. There's some user stats code that seems to be used to track total visits and last 24 hours visits (via setting a 24hr cookie) of the user. Then some "ratings" in a WeatherRater, but i don't see any pages actually using that. And then the mentioned "FuckAdBlock" script is detecting adblock and then setting that boolean in a cookie for some purpose. So... maybe nefarious and abort-on-property-write is worth it, maybe not...

wizmak commented 5 years ago

@dimisa-RUAdList

abort-on-property-write document.cookie

This breaks the temperature unit switch button, language switch button, and the search box.

dimisa-RUAdList commented 5 years ago

Yes, I already noticed.

dimisa-RUAdList commented 5 years ago

Please replace: gismeteo.ua#$#abort-on-property-read localStorage; abort-on-property-read loadMain to > gismeteo.ua#$#abort-on-property-read loadMain

dimisa-RUAdList commented 5 years ago

Please replace: gismeteo.ua#$#abort-on-property-read loadMain to > gismeteo.ua#$#abort-on-property-read eval

dimisa-RUAdList commented 3 years ago

@wizmak @arsykan Del please: gismeteo.ua#$#abort-on-property-read eval

Some temperature graphs break, for example here: https://www.gismeteo.ua/weather-chisinau-4980/14-days/ (old design)