search

abp-filters / abp-filters-anti-cv

GNU General Public License v3.0
174 stars 65 forks source link

ukr.net #457

Closed ditraUA closed 3 years ago

ditraUA commented 4 years ago

List the website(s) where you encounter issues with ABP filters

www.ukr.net

Define the problem

Site is completely hidden

Screenshot(s)

https://i.imgur.com/1S5cxqo.png

List all of your filter lists

RuAdList+Easylist Anti-Circumvention filters (causes the problem)

Tell us about your system configuration

Other details

Site is completely hiding after a second. All is ok with other blokers and if a disable Anti-Circumvention filters I think, Adblock does not correctly support this option: override-property-read

ditraUA commented 4 years ago

This problem is important because ukr.net is very popular mail service in Ukraine. And users ok Adblock can't login into mailbox.

ditraUA commented 3 years ago

Can't repeat it any more. It seems, site made some fixes on it's side.

But I shall not close this issue by myself. May be this information will be useful for other cases.

You can close it after reading.

wizmak commented 3 years ago

Can't repeat it any more. It seems, site made some fixes on it's side.

But I shall not close this issue by myself. May be this information will be useful for other cases.

You can close it after reading.

@ditraUA I can not reproduce the issue as well, and for the record, the filter was tested before pushing, and the site was working without any issues. Thanks for filing this issue!

ditraUA commented 3 years ago

@ditraUA I can not reproduce the issue as well, and for the record, the filter was tested before pushing, and the site was working without any issues. Thanks for filing this issue!

@wizmak Just one question: Was this filter tested in Adblock, not Adblock plus? It blocked whole site only in Adblock. May be that's why you didn't notice a problem?

wizmak commented 3 years ago

@ditraUA

Just one question: Was this filter tested in Adblock, not Adblock plus? It blocked whole site only in Adblock. May be that's why you didn't notice a problem?

It was tested in Adblock Plus only, but it would be very strange if it worked any differently in AdBlock.

ditraUA commented 3 years ago

@ditraUA

It was tested in Adblock Plus only, but it would be very strange if it worked any differently in AdBlock.

The problem was in version 4.20, it has no support of override-property-read rule. I've downloaded versions 4.20 and 4.21 from http://code.getadblock.com/releases/, unpacked sources and found file, that contains "override-property-read" only in 4.21 folder.

And I tried to disable Anti-Circumvention list and apply only this rule: www.ukr.net#$#override-property-read Math.random trueFunc; hide-if-shadow-contains /./

Issue was reproduced only in Adblock (not Plus). But, when I removed this part: override-property-read Math.random trueFunc; Adblock Plus began to work same as Adblock: totally cleaned the page. Unfortunately, I don't understand, what exactly this rule do, so can't give you more details. I asked more experienced guy to help me, but he couldn't reproduce the issue - site made fixes on it's side.

Sorry for alarming, but I have to support tens of employees notebooks remotely (due to quarantine). And it is always a huge problem for me when important sites begin to work incorrectly due to Ad Blockers. Apparently, this case is a good reason for colleagues to replace Adblock with Adblock Plus.

wizmak commented 3 years ago

@ditraUA

The problem was in version 4.20, it has no support of override-property-read rule. I've downloaded versions 4.20 and 4.21 from http://code.getadblock.com/releases/, unpacked sources and found file, that contains "override-property-read" only in 4.21 folder.

I doubt this was the case, if the snippet doesn't exist in the extension's code, the corresponding snippet filter should have no effect.

And I tried to disable Anti-Circumvention list and apply only this rule: www.ukr.net#$#override-property-read Math.random trueFunc; hide-if-shadow-contains /./

Issue was reproduced only in Adblock (not Plus). But, when I removed this part: override-property-read Math.random trueFunc; Adblock Plus began to work same as Adblock: totally cleaned the page. Unfortunately, I don't understand, what exactly this rule do, so can't give you more details. I asked more experienced guy to help me, but he couldn't reproduce the issue - site made fixes on it's side.

Interesting... Unfortunately I also won't be able to figure out what happened, as long as I can/could not reproduce the issue.

Sorry for alarming, but I have to support tens of employees notebooks remotely (due to quarantine). And it is always a huge problem for me when important sites begin to work incorrectly due to Ad Blockers. Apparently, this case is a good reason for colleagues to replace Adblock with Adblock Plus.

No worries! Always feel free to reach out in case you have any questions or issues. Cheers!

dimisa-RUAdList commented 2 years ago

@arsykan @manuel-martinez-dev @wizmak Please add to this rule: 112ua.tv,24boxing.com.ua,4mama.ua,avtovod.com.ua,avtovod.org.ua,besplatka.ua,bilshe.com,buhgalter.com.ua,buhgalter911.com,businessua.com,censor.net,dengi.ua,enovosty.com,epravda.com.ua,eurointegration.com.ua,f1analytic.com,facenews.ua,football-ukraine.com,football24.ua,footballtransfer.com.ua,gismeteo.ua,gorod.dp.ua,hvylya.net,inforesist.org,internetua.com,kolobok.ua,kp.ua,kriminal.tv,lifedon.com.ua,mport.ua,nashamama.com,newsyou.info,nnovosti.info,okino.ua,ostro.org,perevod.i.ua,real-vin.com,sinoptik.ua,smak.ua,sportanalytic.com,toneto.net,tv.ua,tvgid.ua,u-news.com.ua,udoktora.net,vsetv.com,zdorovia.com.ua#$#override-property-read String.prototype.charCodeAt trueFunc- an exception: ~pinformer.sinoptik.ua.

The reason is the breakdown of the weather widget on the ukr.net website - https://i.imgur.com/J66Vf8H.jpg

In principle, you can remove this entire rule altogether. It hasn't been doing anything for a long time, and its only value is that it contains a list of domains that work with zmctrack.

dimisa-RUAdList commented 2 years ago

@arsykan @manuel-martinez-dev @wizmak Up!

wizmak commented 2 years ago

@dimisa-RUAdList I went ahead with the removal of the entire rule as it's no longer useful/needed.

dportvine commented 1 year ago

@wizmak Please dell. This rule is outdated.

www.ukr.net#$#override-property-read Math.random trueFunc; hide-if-shadow-contains /./