Consider changing `IExceptionToErrorInfoConverter` namespace

abpframework / abp

Open-source web application framework for ASP.NET Core! Offers an opinionated architecture to build enterprise software solutions with best practices on top of the .NET. Provides the fundamental infrastructure, cross-cutting-concern implementations, startup templates, application modules, UI themes, tooling and documentation.

https://abp.io

GNU Lesser General Public License v3.0

13k stars 3.46k forks source link

Consider changing `IExceptionToErrorInfoConverter` namespace #15557

Open NecatiMeral opened 1 year ago

NecatiMeral commented 1 year ago

Hi,

The IExceptionToErrorInfoConverter interface and it's implementation are in the Volo.Abp.ExceptionHandling package (which targets netstandard2.0). It's misleading that the components are inside the Volo.Abp.AspNetCore.ExceptionHandling namespace since it can be used on all platforms (wpf, winforms, you name it).

I can contribute a PR which refactors the namespace if it's ok. I just wanted to discuss this idea first.

maliming commented 1 year ago

I agree with you.

NecatiMeral commented 1 year ago

Great, I'll contribute a PR in the upcoming days. 👍

How should I deal with AbpExceptionHandlingOptions? The property names (SendExceptionsDetailsToClients for example) can be refactored to IncludeExceptionsDetails and IncludeStackTrace.

Should I rename them too (breaking change), implement aliases (compatible properties) or leave them as they are (will update the Docs too)?

stale[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.