search

abpframework / abp

Open-source web application framework for ASP.NET Core! Offers an opinionated architecture to build enterprise software solutions with best practices on top of the .NET. Provides the fundamental infrastructure, cross-cutting-concern implementations, startup templates, application modules, UI themes, tooling and documentation.
https://abp.io
GNU Lesser General Public License v3.0
12.8k stars 3.41k forks source link

Why creator id not be set for multi tenant? #17149

Closed qq362220083 closed 1 year ago

qq362220083 commented 1 year ago

We use abp vnext v7.x, and custom tenant logic.

But, we found entity has no creator id.

We found AuditPropertySetter has check entity tenant id logic.

:clown_face: Can you tell us why, thanks. 🚀 🚀 🚀

https://github.com/abpframework/abp/blob/9628bf3deb19ec0987276c2196139c74833e1ddc/framework/src/Volo.Abp.Auditing/Volo/Abp/Auditing/AuditPropertySetter.cs#L70-L76

muhlisatac commented 1 year ago

X tenant user is not belongs to Y tenant. As a Y tenant admin what would you do if you saw a creatorId that is not belongs to Y tenant?

qq362220083 commented 1 year ago

X tenant user is not belongs to Y tenant. As a Y tenant admin what would you do if you saw a creatorId that is not belongs to Y tenant?

Yeah, I see, you are right. Thank you👍

We will replace AuditPropertySetter. 😄