search

abpframework / abp

Open-source web application framework for ASP.NET Core! Offers an opinionated architecture to build enterprise software solutions with best practices on top of the .NET. Provides the fundamental infrastructure, cross-cutting-concern implementations, startup templates, application modules, UI themes, tooling and documentation.
https://abp.io
GNU Lesser General Public License v3.0
12.86k stars 3.43k forks source link

change ABP Prefix to custom name #1924

Closed pranavpatil19 closed 5 years ago

pranavpatil19 commented 5 years ago

public class BlogModule : AbpModule {
}

[DependsOn(typeof(AbpAspNetCoreMvcModule))] [DependsOn(typeof(AbpAutofacModule))] public class BlogModule { }

maliming commented 5 years ago

Can you talk about it in detail?

pranavpatil19 commented 5 years ago

i am working on micro-service project. So i decide to use abp project as base project for that. in abp project satisfy my all requirement. yesterday i demonstrate this project to my senior . he give me a suggestion to remove AbpModule to Module or any Custom prefix like XYZModule .

IS this possible . if yes then how???

public class BlogModule : AbpModule { }

to

public class BlogModule : XyxModule { }

[DependsOn(typeof(AbpAspNetCoreMvcModule))] [DependsOn(typeof(AbpAutofacModule))] public class BlogModule { }

to

[DependsOn(typeof(XyxAspNetCoreMvcModule))] [DependsOn(typeof(XyxAutofacModule))] public class BlogModule { }

maliming commented 5 years ago

Most people will let us add prefixes to modules, options, etc. abp stuff.

I don't understand why you want to remove/change it.

pranavpatil19 commented 5 years ago

i am happy with abp prefix. but Team senior member ask me what is abp? why you write abp? so they suggest me to change abp prefix or dont write abp there ..

hitaspdotnet commented 5 years ago

Don't waste your time, ask your senior to read ABP.io to understanding what is abp. If you changed prefixes you may lose any future updates. @maliming Maybe changing ownership of the product from ABP to TeamSeniorXYZ. I suggest you to read LICENSE.

hikalkan commented 5 years ago

You mean you download the ABP source code, modify it and use in your company as an internal framework. Then you will not be able to get new features and bugfixes we add? I don't think you want that. On the other hand, it is impossible to make Abp prefix changeable per project.

Also, check the license: https://github.com/abpframework/abp/blob/dev/LICENSE (GNU Lesser General Public License v3.0) You should follow the license rules. If you create a modified ABP version (by copying all and modifying), you should make it open source with the same license.