search

abpframework / abp

Open Source Web Application Framework for ASP.NET Core. Offers an opinionated architecture to build enterprise software solutions with best practices on top of the .NET and the ASP.NET Core platforms. Provides the fundamental infrastructure, production-ready startup templates, application modules, UI themes, tooling, guides and documentation.
https://abp.io
GNU Lesser General Public License v3.0
12.31k stars 3.32k forks source link

Update `OpenIddict` to `5.5.0`. #19626

Closed maliming closed 2 weeks ago

maliming commented 3 weeks ago

Resolve #19620

I have tested the OpenID Connect login.

hikalkan commented 3 weeks ago

Can we move this to 8.2?

kevinchalet commented 3 weeks ago

Hey,

Hope you're doing well 👋🏻

FYI, OpenIddict 5.5.0 - released yesterday - still targets IdentityModel 7.4.1 (with all the bugs recently caused by mismatched IdentityModel package versions, I'm now a bit reluctant to bump them 😅).

I see that your Directory.Packages.props references the 7.5.1 version: if it's not already the case, I encourage you to to add explicit, direct references to IdentityModel 7.5.1 in the projects that depend on OpenIddict or the MSFT OIDC or JWT handlers, to avoid any IM version mismatch (which always results in very weird, super hard-to-find bugs 😅)

Here's the 3 IM packages OpenIddict 5.5.0 references: https://github.com/openiddict/openiddict-core/blob/5.5.0/Directory.Packages.props#L334-L336

All the best.

maliming commented 3 weeks ago

Thanks @kevinchalet

We have used the latest(7.5.1) packages in MSFT OIDC and JWT projects.

kevinchalet commented 3 weeks ago

We have used the latest(7.5.1) packages in MSFT OIDC and JWT projects.

👍🏻

(I'll likely bump IdentityModel in the next OpenIddict version, once we're sure there's no weird thing happening 🤣)

maliming commented 3 weeks ago

Can we move this to 8.2?

I have changed the target to prerel-8.2.