search

abpframework / abp

Open Source Web Application Framework for ASP.NET Core. Offers an opinionated architecture to build enterprise software solutions with best practices on top of the .NET and the ASP.NET Core platforms. Provides the fundamental infrastructure, production-ready startup templates, application modules, UI themes, tooling, guides and documentation.
https://abp.io
GNU Lesser General Public License v3.0
12.42k stars 3.34k forks source link

Angular | Refactor modal component #19858

Closed Sinan997 closed 2 weeks ago

Sinan997 commented 1 month ago

Refactor modal component with the new signal API

masumulu28 commented 4 weeks ago

Why we need this changes now ? Also is it ok with current usages ? our setted values are not the signal based type e.g: in identiy component modals

Sinan997 commented 4 weeks ago

Why we need this changes now ? Also is it ok with current usages ? our setted values are not the signal based type e.g: in identiy component modals

Provided value doesn't have to be signal, it can be signal or not. So, it is okey with the current usages. You can test it in your local by sinan/refactor-modal branch.

For more info about model inputs.

As far as i know we want to use new signal features of Angular. According to this idea i have refactor the modal component. If you think this isn't our goal, i can close the PR.