search

abpframework / abp

Open-source web application framework for ASP.NET Core! Offers an opinionated architecture to build enterprise software solutions with best practices on top of the .NET. Provides the fundamental infrastructure, cross-cutting-concern implementations, startup templates, application modules, UI themes, tooling and documentation.
https://abp.io
GNU Lesser General Public License v3.0
12.76k stars 3.41k forks source link

Docs Elastic Search Problem: Search is performed on raw document #3009

Closed yekalkan closed 1 year ago

yekalkan commented 4 years ago

Search is performed before documents is converted to plain text from markdown format and processed by scriban.

image

related https://github.com/abpframework/abp/pull/2901 related https://github.com/abpframework/abp/issues/1621

ebicoglu commented 4 years ago

I've made a progress in the branch https://github.com/abpframework/abp/tree/alper/elastic-search-with-scriban but this is a problematic situation. The Scriban render is made on the web layer because , user preferences are grabbed from the URL. But in the startup, while all docs are being cached to ElasticSearch, we don't know the variables. One way is caching all possible cartesian of variables with different cache keys. See this URL as an example https://docs.abp.io/en/commercial/latest/getting-started?UI=MVC&DB=EF&Tiered=No

ebicoglu commented 4 years ago

this project needs a radical refactor! elastic search section should move to appservice layer. also, rendering MD to HTML should be done in appservice. now, elastic search indexing is done in domain and markdown converters work in Web layer.