search

abpframework / abp

Open Source Web Application Framework for ASP.NET Core. Offers an opinionated architecture to build enterprise software solutions with best practices on top of the .NET and the ASP.NET Core platforms. Provides the fundamental infrastructure, production-ready startup templates, application modules, UI themes, tooling, guides and documentation.
https://abp.io
GNU Lesser General Public License v3.0
12.31k stars 3.32k forks source link

Implement multitenancy on microservice demo #956

Closed hikalkan closed 4 years ago

drony commented 4 years ago

we have been waiting for this demo a long time. we need to make sure it works to start with abp

hikalkan commented 4 years ago

it will work :) No problem on the infrastructure, but this is a complicated case. Need to test all possible flows and probably work on it a bit.

drony commented 4 years ago

To start new projects with this framework, I have to prove my boss that micro service and multi-tenant architecture are working flawlesly and unfortunately I don't have time to learn it, if it works this demo, I'll start without wasting time and start learning. I'm pretty sure a lot of people are waiting for this scenario:)

Best Regards

hikalkan commented 4 years ago

I'm pretty sure a lot of people are waiting for this scenario

I can agree on that, but can not drop currently prioritized works and immediately start to work on that, sorry :( I you don't have time, I can't provide a solution in a very short time.

drony commented 4 years ago

actually we don't expect a demo instantly. just put things right order. we'll wait :) thanks

juicycleff commented 4 years ago

I'm had some success doing this in my project, sorry I cant share the source code as its private. Maybe I can answer some questions. I'm not an expert in DotNet anymore, not programmed in it for 5 years plus, but I can share some insight

drony commented 4 years ago

i'm very sad right now:( postponed this feature to v0.21

hikalkan commented 4 years ago

Multenancy with microservice is complex. I don't say it is not important. It is hard and ABP will add a huge value on it. But we don't want to wait fundamental features and v1.0 release because of it. I hope this will be tested and stabilized before v1.0 release. If not, it will be a vert high priority issue after v1.0.

la-digital commented 4 years ago

Read https://github.com/ThreeMammals/Ocelot/issues/1001#issuecomment-539648158 and was wondering if we might get multi-tenancy on the microservice demo by then :)?

hikalkan commented 4 years ago

Hi all,

I am not able to continue to work on this. We should wait for Ocelot to support asp.net core 3.0. I hope it will be available in the next week, before we release ABP v1.0.

la-digital commented 4 years ago

Will we get this soon now that ocelot supports asp.net core 3.0?

lockcd commented 4 years ago

ocelot supports asp.net core 3.0 ocelot 13.8.0

maliming commented 4 years ago

@lockcd The abp microservices example has been upgraded ocelot 13.8.0

pranavpatil19 commented 4 years ago

again it module move to next road map... hopefully done come in 1.2 roadmap

hikalkan commented 4 years ago

I will work on this just after v1.1 release, but I didn't want to delay the v1.1 release of the framework because of a sample application.

pranavpatil19 commented 4 years ago

again it module move to next road map

hikalkan commented 4 years ago

Yes, it moved again, sorry for it. But there was more significiant problems and you see that we needed to release an early 2.0 to fix the problems with some important changes.

This is a free and open source project. If this is important for you, please consider to send a PR. It would be appreciated.

Tim1104 commented 4 years ago

I'm looking forward to this demo

hikalkan commented 4 years ago

@pranavpatil19 I want to write before you: yes, it is moved again to the next milestone since we will release 2.1 tomorrow and didn't have time to work on this yet, sorry.

pranavpatil19 commented 4 years ago

No issue @hikalkan. Take your time .

hikalkan commented 4 years ago

I am actively working on this on that branch: https://github.com/abpframework/abp/tree/ms-demo-multi-tenant

Changing milestone to 2.3, but milestone has no meaning with this sample, since it is not something released. I will continue to work on.

alan-albuquerque commented 3 years ago

Why are you guys talking like that if it's an open source project? These things takes time and if you really need it, go ahead and do it by yourself, then submit a pull request with it.

Anyway, thanks a lot @hikalkan for your work on it. It's a great framework that I'm really thinking to use in my project.