abr / abr_control

Robotic arm control in Python
Other
417 stars 99 forks source link

Gauss pp #95

Closed p3jawors closed 2 years ago

p3jawors commented 2 years ago

Overhaul of path planners. We now have one master path planner that takes in a position and velocity profile. This allows up to separate the shape of the path we're taking, and the velocity throughout that path. Examples have been updated, and a new section for path_planner examples has been added.

p3jawors commented 2 years ago
studywolf commented 2 years ago

Went through, looks good overall! A couple notes on comments: 1) want to make sure the ones in """ """ are always starting with capital letters and using punctuation at the end, it was a bit inconsistent throughout, 2) we have an 88 char limit, it looked like some were formatted for 60 chars, 3) want to avoid "we" or "our" throughout (sorry i think you picked that up from me, i've been trying to correct it in my own commits).

In the plotting function there was a lot of repeated code; i reduced it quite a bit with some for loops. I believe it's all still plotting the same things but if you could closely compare that would be great, it's possible i missed some things.

I think there's still just the comment for ang, if you could add that in then, then i can do the squashing and it'll be ready to merge!

p3jawors commented 2 years ago

Looked over the edits and they all look good (sorry for the grammar :sweat_smile: ). I tested the plotting and it works fine. I removed theang parameter as we can just check the shape of the path. I also removed a couple redundant scatter plot points in one of the figures. LGTM to merge when you're ready :+1:

studywolf commented 2 years ago

LGTM!