host names for relays aren't working

After seeing a recent commit message mentioning support for host names, I considered switching from IP to hostname. I ran the registration certificate generator script and wondered why the IP was echoed anyway. So I started digging.

Commit https://github.com/abracadaniel/cardano-pool-docker/commit/427e01d45e37a2b9c339d7bdb63b4e274116c6ec claims to introduce support for host names, but as far as I can see it only collects the information but does not apply the information when it comes to generate the certificate using the cardano-cli.

In the current master you can see the cli still receives the --pool-relay-ipv4 ${PUBLIC_RELAY_IP} no matter if PUBLIC_RELAY_HOST was provided or not https://github.com/abracadaniel/cardano-pool-docker/blob/master/scripts/generate_registration_certificates#L125

Another thing I noticed is that, even though its not used later, the option "--pool-relay-host ${PUBLIC_RELAY_HOST}" defined on this line https://github.com/abracadaniel/cardano-pool-docker/blob/master/scripts/generate_registration_certificates#L90 might not be correct. cardano-cli stake-pool registration-certificate --help shows following options available (--pool-relay-host does not exist)

  --pool-relay-ipv4 STRING The stake pool relay's IPv4 address
  --pool-relay-ipv6 STRING The stake pool relay's IPv6 address
  --pool-relay-port INT    The stake pool relay's port
  --single-host-pool-relay STRING
                           The stake pool relay's DNS name that corresponds to
                           an A or AAAA DNS record
  --pool-relay-port INT    The stake pool relay's port
  --multi-host-pool-relay STRING
                           The stake pool relay's DNS name that corresponds to
                           an SRV DNS record

abracadaniel / cardano-pool-docker

host names for relays aren't working #51