Closed dsn closed 9 years ago
@dsn Read your PR. Sorry for delay. Your conditional logic change was noted here:
Your logic would require the port to be 443 OR the uri.scheme == 'https'
If I understood that correctly the case would fail when the port is 443 AND uri.scheme='https' which is a legitimate situation. Thoughts?
OR means one or more of its operators should be true https://en.wikipedia.org/wiki/Logical_disjunction
@tampakrap been a bit of a space cadet this week. You are correct. Forgot my days of symbolic logic there.
added check for uri.scheme to determine if we should use ssl to connect to the remote server_url