abrader / abrader-gms

Git management system types and providers for Puppet utilizing Github, Gitlab, Stash APIs
Apache License 2.0
26 stars 32 forks source link

Support SSL on ports other than 443 #18

Closed dsn closed 9 years ago

dsn commented 9 years ago

added check for uri.scheme to determine if we should use ssl to connect to the remote server_url

abrader commented 9 years ago

@dsn Read your PR. Sorry for delay. Your conditional logic change was noted here:

https://github.com/dsn/abrader-gms/blob/4a7882546e8995ec18be8663cb8f7bd6c9fdc000/lib/puppet/parser/functions/gitlab_add_deploy_key.rb#L20

Your logic would require the port to be 443 OR the uri.scheme == 'https'

If I understood that correctly the case would fail when the port is 443 AND uri.scheme='https' which is a legitimate situation. Thoughts?

tampakrap commented 9 years ago

OR means one or more of its operators should be true https://en.wikipedia.org/wiki/Logical_disjunction

abrader commented 9 years ago

@tampakrap been a bit of a space cadet this week. You are correct. Forgot my days of symbolic logic there.