Updated version of gms module (includes #40 and #47)

abrader / abrader-gms

Git management system types and providers for Puppet utilizing Github, Gitlab, Stash APIs

Apache License 2.0

26 stars 32 forks source link

Updated version of gms module (includes #40 and #47) #50

Open bjvrielink opened 5 years ago

bjvrielink commented 5 years ago

Updated metadata.json (support for newer Puppet and Stdlib)
Fixed Travis
Added Gitlab CI
Incorporated #40 and #47, so this version can now be used again with Gitlab.

PS. Please consider migrating this module to VoxPupuli (#46)...

jdub55 commented 5 years ago

+1 to moving this to the community. This is a very helpful module and I think it's important to have reliable way to make future updates and merges.

bjvrielink commented 5 years ago

@abrader Is there anything we can help you with getting a new version of this module published on the Puppet forge?

benh57 commented 5 years ago

Any chance of getting this merged?

abrader commented 4 years ago

My apologies on the delay of this reply. If this is still of interest to you, please let me know.

jdub55 commented 4 years ago

Based on my knowledge and issues encountered in the past, this module needs to be API version aware so it can be used with newer versions of the GitLab API...

bjvrielink commented 4 years ago

I'm stiil using this module in combination with Gitlab today. I've upgraded to just about every Gitlab release that came out while this PR was open, and do not recall any issues. At the moment I only use the git_deploy_key type, but have also used git_webhook in the past.

The only thing I'd like to add to my PR right now is to increase the dependencies on Puppet version and stdlib version. The latter one also means dropping support for Puppet < 5.5. Any thoughts on that?

bschonec commented 2 years ago

I can confirm that this fix works for RHEL7 and RHEL8 on Puppet Server 7.6.0 and newer. Can we please get a merge?

bjvrielink commented 2 years ago

@bschonec it looks like @abrader isn't really active on Github anymore? I don't know if anyone else has the rights to do merges on this repository.

Alternatively, someone should fork this module and push that to the Puppet Forge. I do still use this module, but am not involved enough with it to be the best candidate for such a fork right now. Maybe @voxpupuli can help?

bschonec commented 2 years ago

I sent an email to abraders' address but he has not replied.