Closed horgag1 closed 5 years ago
abraham
commented
5 years ago This is fantastic! There is a lot going on in this though. Please split this up into multiple PRs
BadConnection widget.CircularProgressIndicatorFor the other changes, I'll need more information around what they are accomplishing. For example, there is already a .idea folder in app, why should there be another one in the root directory?
horgag1
commented
5 years ago Apologies Abraham, I haven't contributed to a project before, so a bit of a newbie when it comes to the git workflow. I'll spit my contributions to multiple PRs. Maybe one PR for each "help wanted". I've added a few tests as well and I'll put them in different PRs. I've no idea how I managed to generate the .idea folder(I have it in my gitignore file) but I'll delete it on my repository. I've seen the other issues(help wanted) and I'll tackle them over the weekend. I wouldn't fell comfortable writing a Contribution file (because of the above reasons) but don't hesitate to tell me what I'm doing wrong and the way you want me to proceed with PRs etc.. Assume I don't no very much about git! All the best, Gerard.
abraham
commented
5 years ago @horgag1 no problem. I'm more than happy to work through the process with you. I'll claim the contributions issue since really that's something I should write.
The general rule of thumb is to do a single pull request per open issue you are completing. That should include the functionality changes and the tests verifying them. The PRs should generally not include any other/unrelated changes.
Before starting to work on an issue be sure no one else is assigned to it and then make a comment that you have started working on it. If you have questions about how something should be implemented (I'm not always great about including all the details in an issue) it's better to ask before starting the work.
I'm going to close this PR and I look forward to your new ones :1st_place_medal:
Hi, just added the error and loading indicator...updated the tests