abrahamjuliot / creepjs

Creepy device and browser fingerprinting
MIT License
1.54k stars 194 forks source link

Suggestions for improving maintainability and use the library as a NPM package #193

Open mrauhu opened 2 years ago

mrauhu commented 2 years ago

Hello, @abrahamjuliot.

I want to implement best practices in the tooling based on the Vite repository.

The goal is to make it easier for maintainers to participate in the project and allow users use the library as a NPM package.

Checklist

Zero changes to the code

Minor changes to the code

Minor changes to the package code: syntax and typing

Minor changes in the package.json and Github Actions

Major changes to the code


  1. Are you ready to accept such changes?
  2. May I create a one pull request with all suggested features?

Best wishes, Sergey.

abrahamjuliot commented 2 years ago

Hey @mrauhu Thank you for the well outlined suggestions.

Let's pause on making all these changes. We do want to avoid creating a fingerprinting library package. The primary goal is only to promote research and education on the subject of browser fingerprinting.

linting, types, etc

Good tips. I will look into this. Just ported the js to ts recently (a work in progress). The goal is to convert all .ts files to strict types (no any or ts-ignore) and split up functions into subdirectories (utils, constants, template, types).

disable default API request

This is on my mind.

package.json

These are all great tips. I will look at each.

/docs is sort of a final release for GitHub pages. public is a commit staging environment for mass browser testing. docs/tests is for playground fingerprinting ideas. I intend to add functional tests soon (Playwright and Jest).

mrauhu commented 2 years ago

@abrahamjuliot thank you for response.