docs: Update example to use `.attachFile` rather than `.upload`

abramenal / cypress-file-upload

File upload testing made easy

https://npm.im/cypress-file-upload

MIT License

496 stars 89 forks source link

docs: Update example to use `.attachFile` rather than `.upload` #271

Closed edhollinghurst closed 3 years ago

edhollinghurst commented 3 years ago

Checklist:

[ ] No linting issues
[ ] Commits are compliant with commitizen
[ ] CI tests have passed
[ ] Documentation updated

Summary of changes

Please provide here description of how this PR changes the codebase and the application and/or what bugs it fixes.

Linked issues

You might use keyword combinations like"Closes #1" to link issues or other related PRs

inovramadani commented 3 years ago

@abramenal please merge this asap as the readme is misleading and confusing a lot of people. I upgraded my cypress-file-upload from version 3.2.0 to 5.0.2 and surprised that all my test codes using .upload don't work.

abramenal commented 3 years ago

@all-contributors add @edhollinghurst for doc

allcontributors[bot] commented 3 years ago

@abramenal

I've put up a pull request to add @edhollinghurst! :tada:

abramenal commented 3 years ago

Thanks for pointing out, good catch