Remove "change" from drag-n-drop events

michaeljaltamirano commented 3 years ago

Checklist:

[x] No linting issues
[x] Commits are compliant with commitizen
[x] CI tests have passed
[x] Documentation updated
- No updates required, JSDoc comment linking to MDN in source code

Summary of changes

A repository I work on is seeing files uploaded twice as mentioned in #276.

I dug into the local /dist of this library and noticed that removing 'change' from the SUBJECT_TYPE.DRAG_N_DROP values resolved my issue locally. It looks like 'change' is not included in the MDN docs for DragEvent.

It looks like the tests set up in this library are still passing, so I'm curious to see if this fixes people's issues without causing any regressions 🙂

Linked issues

Closes #276

abramenal commented 3 years ago

@all-contributors add @michaeljaltamirano for code

allcontributors[bot] commented 3 years ago

@abramenal

I've put up a pull request to add @michaeljaltamirano! :tada:

abramenal commented 3 years ago

Great job @michaeljaltamirano! Let me release this now

abramenal commented 3 years ago

Released in v5.0.5

8gentile commented 3 years ago

Awesome work gang, thanks!

abramenal / cypress-file-upload