search

abramenal / cypress-file-upload

File upload testing made easy
https://npm.im/cypress-file-upload
MIT License
496 stars 89 forks source link

Fix Firefox Drag'n'Drop Functionality #294

Closed michaeljaltamirano closed 3 years ago

michaeljaltamirano commented 3 years ago

Checklist:

Summary of changes

290 broke Firefox compatibility. This PR adds a specific check to see if the Cypress runner broswer is Firefox to manually add 'change' into the drag'n'drop list of events because its presence was casing duplication for Chrome (see #276).

Draft PR instead of ready for review because we should probably add tests that try and repro some of these issues (either Chrome duplication, or Firefox upload functionality broken) so that we don't play whack-a-mole with patch PRs.

Linked issues

Closes #293

abramenal commented 3 years ago

Okay, I have finally brought Firefox tests back. Now, please rebase your branch with latest main, so it'll run whole testing suite based on latest configuration changes. Hope it'll be all green 🤞

michaeljaltamirano commented 3 years ago

Okay, I have finally brought Firefox tests back. Now, please rebase your branch with latest main, so it'll run whole testing suite based on latest configuration changes. Hope it'll be all green 🤞

Looks green 🙏 Hopefully no more issues pop up 😬

abramenal commented 3 years ago

@all-contributors add @michaeljaltamirano for question and code

allcontributors[bot] commented 3 years ago

@abramenal

I've put up a pull request to add @michaeljaltamirano! :tada:

abramenal commented 3 years ago

Coool stuff, it is all green now! https://github.com/abramenal/cypress-file-upload/actions/runs/751210777

Thanks a lot for your effort @michaeljaltamirano, really appreciate that! 💪 I have deprecated v5.0.5 and published a new version containing your changes.