abramenal / cypress-file-upload

File upload testing made easy
https://npm.im/cypress-file-upload
MIT License
496 stars 89 forks source link

Remove cypress types reference #306

Closed jtneal closed 3 years ago

jtneal commented 3 years ago

Fixes #305

I admittedly don't understand what side-effect removing this line will have. I've only worked with types in TypeScript projects where the declarations file are generated by the TypeScript compiler rather than those written manually such as this. However, I don't think we need these types pulled in as a dependency here because you're not even using them - so they are just added to the global namespace without really adding any value.

Alos, Cypress users using TypeScript will already have cypress types pulled in with their tsconfig file, e.g. "types": ["cypress"],.

Checklist:

Summary of changes

Please provide here description of how this PR changes the codebase and the application and/or what bugs it fixes.

Linked issues

You might use keyword combinations like"Closes #1" to link issues or other related PRs

abramenal commented 3 years ago

@all-contributors add @jtneal for code

allcontributors[bot] commented 3 years ago

@abramenal

I've put up a pull request to add @jtneal! :tada:

abramenal commented 2 years ago

@all-contributors add @jtneal for code

allcontributors[bot] commented 2 years ago

@abramenal

I've put up a pull request to add @jtneal! :tada: