abraunegg / onedrive

OneDrive Client for Linux
https://abraunegg.github.io
GNU General Public License v3.0
10.12k stars 862 forks source link

onedrive --no-remote-delete doesn't seem to work as expected #118

Closed simon57nz closed 6 years ago

simon57nz commented 6 years ago

Bug Report Details

Describe the bug After installing onedrive all works well except that when I run onedrive --synchronize --no-remote-delete -- upload-only after removing a local folder the folder was immediately removed from OneDrive.

Application and Operating System Details:

To Reproduce Steps to reproduce the behavior if not causing an application crash:

  1. Copy Folder to OneDrive folder
  2. Run onedrive --synchronise
  3. Delete Folder
  4. Run onedrive --synchronize --no-remote-delete -- upload-only
  5. Folder on OneDrive is deleted

Responses are : Initializing the Synchronization Engine ... Syncing changes from local path only - NOT syncing data changes from OneDrive ... Deleting item from OneDrive: Tui/Liturgy

If issue is replicated by a specific 'file' or 'path' please archive the file and path tree & email to support@mynas.com.au

Complete Verbose Log Output A clear and full log of the problem. Please use 3 ` characters to format log output to make it easier to read. See https://guides.github.com/features/mastering-markdown/ for more details.

Screenshots If applicable, add screenshots to help explain your problem.

Additional context Add any other context about the problem here.

Bug Report Checklist

abraunegg commented 6 years ago

Please can you provide the full command line you used.

The --no-remote-delete only is applied when using --upload-only

simon57nz commented 6 years ago

I am editing the report at present, amazingly fast reply from you.

onedrive --synchronize --no-remote-delete -- upload-only

Simon

On 13 August 2018 at 10:08, abraunegg notifications@github.com wrote:

Please can you provide the full command line you used.

The --no-remote-delete only is applied when using --upload-only

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/abraunegg/onedrive/issues/118#issuecomment-412375300, or mute the thread https://github.com/notifications/unsubscribe-auth/AYj9AyZkTpQ8NyU3dp5Zgqwvg8aF8fVZks5uQKd6gaJpZM4V5tHa .

-- Rgds, Simon Moseley

simon57nz commented 6 years ago

Currently working on getting more details of the output messages for you, but the syncronizing is taking longer than yesterday.

On 13 August 2018 at 10:11, Simon Moseley simon@moseley.co.nz wrote:

I am editing the report at present, amazingly fast reply from you.

onedrive --synchronize --no-remote-delete -- upload-only

Simon

On 13 August 2018 at 10:08, abraunegg notifications@github.com wrote:

Please can you provide the full command line you used.

The --no-remote-delete only is applied when using --upload-only

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/abraunegg/onedrive/issues/118#issuecomment-412375300, or mute the thread https://github.com/notifications/unsubscribe-auth/AYj9AyZkTpQ8NyU3dp5Zgqwvg8aF8fVZks5uQKd6gaJpZM4V5tHa .

-- Rgds, Simon Moseley

-- Rgds, Simon Moseley

abraunegg commented 6 years ago

Can you help validate PR #119 to resolve your issue:

git clone https://github.com/abraunegg/onedrive.git
cd onedrive
git fetch origin pull/119/head:pr119
git checkout pr119
make
make install

Local validation testing:

./onedrive --version
onedrive v2.1.0-5-g7dffced
./onedrive --synchronize --verbose --upload-only --no-remote-delete
Loading config ...
Using Config Dir: /root/.config/onedrive
No config file found, using defaults
Initializing the OneDrive API ...
Opening the item database ...
All operations will be performed in: /root/OneDrive
Initializing the Synchronization Engine ...
Account Type: personal
Default Drive ID: 66d53be8a5056eca
Default Root ID: 66D53BE8A5056ECA!101
Remaining Free Space: 5271641600
Fetching details for OneDrive Root
OneDrive Root exists in the database
Syncing changes from local path only - NOT syncing data changes from OneDrive ...
Uploading differences of .
Processing root
The directory has not changed
Processing myfile.tar.gz
The file has not changed
Processing testdir
The directory has been deleted locally
Skipping remote directory delete as --upload-only & --no-remote-delete configured
Uploading new items of .
simon57nz commented 6 years ago

output.txt

Now works as expected, Thank You Output in txt file

simon57nz commented 6 years ago

Thank you for the help.

On 13 August 2018 at 10:59, abraunegg notifications@github.com wrote:

Can you help validate PR #119 https://github.com/abraunegg/onedrive/pull/119 to resolve your issue:

git clone https://github.com/abraunegg/onedrive.git cd onedrive git fetch origin pull/119/head:pr119 git checkout pr119 make make install

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/abraunegg/onedrive/issues/118#issuecomment-412377741, or mute the thread https://github.com/notifications/unsubscribe-auth/AYj9A5KPY1mNgeapGw5I0VIE9QDgnaRWks5uQLNfgaJpZM4V5tHa .

-- Rgds, Simon Moseley

lock[bot] commented 5 years ago

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.