abraunegg / onedrive

OneDrive Client for Linux
https://abraunegg.github.io
GNU General Public License v3.0
10.18k stars 866 forks source link

Feature Request: Permanent Delete on OneDrive #2803

Open NovaPixell opened 2 months ago

NovaPixell commented 2 months ago

@NovaPixell

Is there an option (like on rclone) to enable permanent delete on OneDrive?

Unfortunately no such option exists currently. Please raise a feature request.

Additionally, due to the current development cycle, this will be looked at for some version in v2.5.x and cannot be considered for inclusion in v2.5.0.

Reference:

Originally posted by @abraunegg in https://github.com/abraunegg/onedrive/discussions/2802#discussioncomment-10645537

abraunegg commented 11 hours ago

@NovaPixell

Please can you test PR #2999 that implements your feature request.

First install all the require platform dependencies to build the client on your platforms. Please read https://github.com/abraunegg/onedrive/blob/master/docs/install.md#building-from-source---high-level-requirements and then follow correctly for your platform.

Once this is done, to clone the PR to resolve your issue, you can use a script like the following:

#!/bin/bash

PR=2999

rm -rf ./onedrive-pr${PR}
git clone https://github.com/abraunegg/onedrive.git onedrive-pr${PR}
cd onedrive-pr${PR}
git fetch origin pull/${PR}/head:pr${PR}
git checkout pr${PR}

# Configure and Build
./configure --enable-debug --enable-notifications; make clean; make;
./onedrive --version

This script will create a local folder called onedrive-pr2999 with the PR version.

To run the PR, you need to run the client from the PR build directory:

./onedrive <any other options needed>

To install the PR, you will need to perform sudo make install to install the PR version to your system.

When running the PR, your version should be: onedrive v2.5.3-9-ge8a8dfb or greater.

To activate the new feature, this can ONLY be done from the 'config' file:

permanent_delete = "true"
The Microsoft OneDrive API for this capability is also very narrow: Account Type API is Supported
Personal
Business
SharePoint
Microsoft Cloud Germany
Microsoft Cloud for US Government
Azure and Office365 operated by VNET in China

When running against an unsupported Personal Account the following message will be generated:

WARNING: The application is configured to permanently delete files online; however, this action is not supported by Microsoft OneDrive Personal Accounts.

When running against a supported account the following message will be generated:

WARNING: Application has been configured to permanently remove files online rather than send to the recycle bin. Permanently deleted items can't be restored.
WARNING: Online data loss MAY occur in this scenario.

Please can you test and provide your feedback.