Feature Request: Allow disabling update check

[skbeh]

Is your feature request related to a problem? Please describe.

The update check blocks the OneDrive API initialization and slows down the startup.

Describe the solution you'd like

Add a config option to disable the update check.

Describe alternatives you've considered

Make the update check async.

Additional context

No response

[abraunegg]

@skbeh The update check is there for a specific reason.

Rejecting this

[skbeh]

@abraunegg In my isolated environment, the access to Microsoft service is allowed while GitHub is not, and the check pops errors every time. So I think it's a reasonable use case.

[abraunegg]

@skbeh So .. potentially some self learning here:

The update check blocks the OneDrive API initialization and slows down the startup. ....... In my isolated environment, the access to Microsoft service is allowed while GitHub is not, and the check pops errors every time

Please always add all information including full context .... otherwise there is no context as to why this is slowing down startup.

Any developer needs full context to understand a problem to respond in an applicable manner.

So I think it's a reasonable use case.

Whilst it may be a reasonable use case, it is there for a very good reason. If you had this option, and enabled it, then you would never get real-time notifications when there is a new client release, which fixes known issues and problems and adds new features.

Likewise, it is my reasonable question - why can your isolated environment be updated to allow the outbound communication to GitHub for that evaluation? That is a reasonable question to ask.

Secondly, please refer to the architecture documentation that clearly calls out how this client works:

https://github.com/abraunegg/onedrive/blob/master/docs/client-architecture.md

The GitHub version check is not something new, this has been in the client v2.4.16 which was released in March 2022.

[skbeh]

@abraunegg

If you had this option, and enabled it, then you would never get real-time notifications when there is a new client release, which fixes known issues and problems and adds new features.

My package manager already does it.

why can your isolated environment be updated to allow the outbound communication to GitHub for that evaluation?

The access to Microsoft is allowed to enable collaboration on Microsoft 365. Unfortunately, GitHub is not on the allowlist.

[abraunegg]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.