Employ reconnect behavior on amqplib close events

abreits / amqp-ts

AmqpSimple, a RabbitMQ tested Amqp library written in and for Typescript

MIT License

133 stars 37 forks source link

Employ reconnect behavior on amqplib close events #29

Closed alavers closed 5 years ago

alavers commented 5 years ago

Fixes a bug where amqp-ts would fail to reconnect in the event that a node in a RabbitMQ cluster was cycled. In this case, amqplib emits a close event which amqp-ts fails to listen for. Fixes https://github.com/abreits/amqp-ts/issues/27

abreits commented 5 years ago

I have not tested your fix, but glanced through the code and it seems OK. Due to personal circumstances I do not have the energy to fully support this project and keep it up to date, so if you or anyone else wants to take over this library, be my guest (just tell me what to do)

alavers commented 5 years ago

@abreits Thanks for the quick look! I could help as maintainer but probably only in the capacity of reviewing PRs. I wouldn't work on closing issues unless they directly impact us for example.

My team has been using a shallow fork of this lib for a while now, but to be brutally honest we have plans to move away from it in the future and work off of amqplib directly.