search

abreits / amqp-ts

AmqpSimple, a RabbitMQ tested Amqp library written in and for Typescript
MIT License
133 stars 37 forks source link

Update amqplib version from 0.4.x (0.4.2) to 0.5.x (0.5.5) #45

Open austin-beer opened 5 years ago

austin-beer commented 5 years ago

amqp-ts currently uses an outdated version of amqplib. This PR updates it to use the latest version.

Changelog for amqplib: https://github.com/squaremo/amqp.node/blob/master/CHANGELOG.md

uminac commented 4 years ago

it seems like this could possibly fix node-red-contrib-amqp when run in docker:

2020-02-23T20:50:28.450Z Install : node-red-contrib-amqp 1.0.2

2020-02-23T20:50:28.552Z npm install --no-audit --no-update-notifier --save --save-prefix="~" --production node-red-contrib-amqp@1.0.2
2020-02-23T20:50:33.846Z [err] npm
2020-02-23T20:50:33.846Z [err]  WARN notsup Unsupported engine for amqplib@0.4.2: wanted: {"node":">=0.8 <6 || ^6"} (current: {"node":"10.19.0","npm":"6.13.4"})
2020-02-23T20:50:33.846Z [err] npm WARN notsup Not compatible with your version of node/npm: amqplib@0.4.2
2020-02-23T20:50:33.847Z [err] 
2020-02-23T20:50:33.850Z [out] + node-red-contrib-amqp@1.0.2
2020-02-23T20:50:33.850Z [out] added 22 packages from 61 contributors in 3.782s
2020-02-23T20:50:33.906Z rc=0
CN91 commented 4 years ago

Can this please be merged ?!

uminac commented 4 years ago

might as well go to amqplib v0.5.6

CN91 commented 4 years ago

Yes but then it still needs to be merged! ;)

romiras commented 3 years ago

2 years passed and still not merged. :-(

abreits commented 3 years ago

Sorry, better consider this dead. I unfortunately have no time to keep this library up to date (it is already very outdated). Our organization also does not use it any more.

Also new technologies (e.g. async await) and versions of libraries it is built upon have made it more or less obsolete for most purposes.

From: Roman Mirr @.> Sent: donderdag 14 oktober 2021 12:10 To: abreits/amqp-ts @.> Cc: Subscribed @.***> Subject: Re: [abreits/amqp-ts] Update amqplib version from 0.4.x (0.4.2) to 0.5.x (0.5.5) (#45)

2 years passed and still not merged. :-(

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/abreits/amqp-ts/pull/45#issuecomment-943212610 , or unsubscribe https://github.com/notifications/unsubscribe-auth/ABCPLHMVFBDIENYQVYHDEM3UG2UAPANCNFSM4I73THVQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub . https://github.com/notifications/beacon/ABCPLHK64VSYJ572CTYLR7TUG2UAPA5CNFSM4I73THV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOHA4EQQQ.gif