search

abreits / node-red-contrib-oracledb

Node-RED oracle database nodes
8 stars 15 forks source link

pass on the orginal message not create a new one #17

Open emra700 opened 6 years ago

emra700 commented 6 years ago

node needs to be fixed to pass on the orginal message not create a new one.

knolleary commented 6 years ago

It appears a fix for this was merged here: https://github.com/abreits/node-red-contrib-oracledb/pull/12 but a new version has not been published to npm.

You should be able to install the fix by running npm install abreits/node-red-contrib-oracledb in your ~/.node-red directory - you won't be able to do it via the palette manager until it gets published to npm.

abreits commented 6 years ago

Should be fixed now

ctlemp2018 commented 6 years ago

I just tried the updated node (version 0.5.0) but a http request / response node in combination with node-red-contrib-oracledb is still not working. Have you checked the updated package? Also the documentation on npm of the node is not updated with the fixes for 0.5.0

image

image

ctlemp2018 commented 6 years ago

I checked the bin\oracledb.js file for version 0.5.0, but the changes to pass the msg inside your functions are not in this version?

Can you please check the changes in https://github.com/abreits/node-red-contrib-oracledb/pull/12/files/55384e269770ab228c3bd125afff8bf2f55bbb16 with the file you have in 0.5.0?

abreits commented 6 years ago

I was too fast, should be fixed now (I cannot test this at my current location, no oracle stuff installed, so npm install node-red-contrib-oracledb fails :( ).

ctlemp2018 commented 6 years ago

Thank you, I will check the new version later this afternoon and give you feedback.

ctlemp2018 commented 6 years ago

I can confirm now that version 0.5.1 fixes the problem and now passes the original message correctly. Http request/response nodes can now be used correctly in combination with the oracledb node.

Thank you for your support & initial work to create this node. Keep up the good work!