abrenneke / rivet-plugin-chromadb

Rivet plugin for integrating with Chroma, the open-source embedding database
4 stars 1 forks source link

Chroma Update node requires Embeddings to update the metadata #1

Open igor2c opened 9 months ago

igor2c commented 9 months ago

In Chroma plugin, is should be possible to update the metadata without remaking the embeddings from scratch.

The Chroma Update node currently requires Embeddings input: https://github.com/abrenneke/rivet-plugin-chromadb?tab=readme-ov-file#chroma-update

However, Embeddings are optional on the Chroma side.

gengen1988 commented 7 months ago

I made a pull request for this feature: #2

I have noticed when send a doc without embedding, chroma client will try to generate a new embedding with its embeddingFunction in collection. I put an empty array for this case since we usually calculate embedding in other node in rivet.

reference: https://docs.trychroma.com/usage-guide#using-collections