search

abrenoch / hyperion-android-grabber

Screen grabber for hyperion
MIT License
193 stars 31 forks source link

Bug/tv assertion error #113

Closed ninovanhooff closed 6 years ago

ninovanhooff commented 6 years ago

[TV] Catch all settings assertion errors and annotate for Java interop

...apparently Kotlin does not have Checked exceptions. Fixes a crash when the user tapped the setup Test button while hostname value was invalid. This was caused by the expected AssertionError not being caught.

Fixes https://github.com/abrenoch/hyperion-android-grabber/issues/105

ninovanhooff commented 6 years ago

I feel like throwing fatal exceptions is somehow against Kotlin philosophy, but what would be the use of exceptions then? Don't really understand what is expected of developers here, but I documented the behavior and fixed the bug

abrenoch commented 6 years ago

Also, I switched the branch to merge into to the development, just FYI!