search

abrenoch / hyperion-android-grabber

Screen grabber for hyperion
MIT License
193 stars 31 forks source link

Doesn't seem to use hyperion's config #118

Closed pmishev closed 5 years ago

pmishev commented 5 years ago

When playing a video in the Plex app, it doesn't seem to handle the black bars on top and bottom, which is configured in hyperion.json. Additionally in the configuration I have to setup the number of horizontal and vertical pixels - why do I have to do that, if these are configured in the hyperion config as well?

Perhaps I don't understand how the whole things works - I thought the app just captures the screen and sends the data to the hyperion server for processing and lighting the LEDs?

Joeboyc2 commented 5 years ago

Thats a good point actually and I did wonder why I was being asked when setting up the latest version recently

Be good to understand this please

abrenoch commented 5 years ago

Fair question @pmishev, I'll explain.

The app will use that information to determine what quality of image will be sent to hyperion. To maintain the correct aspect ratio, we can only scale by the common divisors for both the width & height of your device's screen. Rather than leaving it up to the user to determine the optimal quality, the app will calculate the lowest quality acceptable for the number of LEDs in your setup. Sending a higher image quality than needed will simply consume more resources on your device without really getting any benefit out of it, so this will do that work for you!

For the black bars, could you make sure the black border threshold in your hyperion settings in greater than 0 (I use 0.01). I'm honestly not sure why that makes the difference but it appears to!

ninovanhooff commented 5 years ago

Note that you can enter the values yourself because hyperion does not expose that kind of setup information to us.

The default values should work well for most people though. Thats why we put it under the advanced section

On Tue, 18 Sep 2018, 14:55 Dave Anderson, notifications@github.com wrote:

Fair question @pmishev https://github.com/pmishev, I'll explain.

The app will use that information to determine what quality of image will be sent to hyperion. To maintain the correct aspect ratio, we can only scale by the common divisors for both the width & height of your device's screen. Rather than leaving it up to the user to determine the optimal quality, the app will calculate the lowest quality acceptable for the number of LEDs in your setup. Sending a higher image quality than needed will simply consume more resources on your device without really getting any benefit out of it, so this will do that work for you!

For the black bars, could you make sure the black border threshold in your hyperion settings in greater than 0 (I use 0.01). I'm honestly not sure why that makes the difference but it appears to!

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/abrenoch/hyperion-android-grabber/issues/118#issuecomment-422381392, or mute the thread https://github.com/notifications/unsubscribe-auth/AJ3xn4480D0cK-vn6b2RwCtAYiWlMrLEks5ucO0ygaJpZM4Wtymc .

abrenoch commented 5 years ago

Haven't heard any updates here, so I'm going to close this. Just respond if there is still a problem.