abrenoch / hyperion-android-grabber

Screen grabber for hyperion
MIT License
193 stars 31 forks source link

[Enhancement] Image Process Settings #151

Open tarchive opened 4 years ago

tarchive commented 4 years ago

Hi, First off, great work! I was previously running the HDMI signal -> HDMI splitter -> HDMI to Composite converter ->USB TV tuner -> Raspberry pi Hyperion. With one simple install of your app to my Zidoo X9S Android box and entering the IP, everything worked instantly and was much more responsive than my previous setup. This really is the way to go if you have an android box with an HDMI input.

The only problem i have is due to a nonexistent setting that i cannot change. Just like the default settings in Hyperion v4l2 grabber, your app also uses too deep of a capture region for me. For example when i watch a movie with subtitles, all the bottom LEDs are a solid white/ yellow light matching the subtitle color. It is very distracting in dark scenes

My fix for this with Hyperion was to adjust the Image Process depth setting to a lower value that would miss catching the subtitles. Since this problem has appeared again after switching to your grabber i am assuming this is a setting you would need to incorporate?

I tried to look for a similar setting with your app but i do not see one. Would you consider adding a setting like this this or recommending an alternative? Thank you!

Hyperion Image Process

I may be wrong about this whole issue here because i assuming a lot that i do not fully understand. I do not know how much of the workload is split between this android grabber and the Hyperion controller and where this issue can be/ should be resolved. Please correct me if i am wrong.

abrenoch commented 4 years ago

Hey there @tarchive, thanks for taking the time to submit a detailed issue.

I'll look into this a little bit... It seems like those settings should still be applied to the image the app is sending to hyperion. However, the app does some math to determine what quality of image should be sent. This is what the horizontal/vertical LED count is used for in the settings. The app determines what size of image should be sent to best match the qty of LEDs you are running, but this also means the pixels from the subtitles are getting mixed into the downscaled image.

What you could try out is bumping up those LED counts in the settings. That will send a higher quality image to hyperion, but that may be at some performance expenses. Try doubling or tripling the number you entered there and you may start to see the behavior you are describing.