abrenoch / hyperion-android-grabber

Screen grabber for hyperion
MIT License
194 stars 33 forks source link

Reload settings when settings are closed / updated #34

Closed ninovanhooff closed 6 years ago

ninovanhooff commented 6 years ago

It seems that the TV app does not notice that the host has been filled until the app is restarted

reproduce: with a fresh install of the app:

expected: hyperion is turned on actual: toast message: Host must not be empty

After an app restart, the host is used, so the persistence is not the problem. Settings should be reloaded when settings are closed.

I'd be happy to fix this

abrenoch commented 6 years ago

Good catch - if you would like to submit a fix I would be glad to merge a PR!

ninovanhooff commented 6 years ago

Will do.

abrenoch commented 6 years ago

Hey @ninovanhooff is this still an issue? In my testing of different branches and uninstalling/reinstalling the app I haven't ran into this problem!

ninovanhooff commented 6 years ago

Exactly what I just found out! closing