search

abrenoch / hyperion-android-grabber

Screen grabber for hyperion
MIT License
194 stars 33 forks source link

Feature/tv ui #36

Closed ninovanhooff closed 6 years ago

ninovanhooff commented 6 years ago

Adds some eye candy for the TV UI

Also drags the Settings icon closer to the center of attention, and add some visual feedback of what icon is currently selected and focused.

Note: Built on top of my previous PR https://github.com/abrenoch/hyperion-android-grabber/pull/32 , merging that one first will give a clear overview of the changes

abrenoch commented 6 years ago

Hey I'm really loving the animation! That is what I wanted to work towards but didn't want to get distracted from making a working product, so thanks for taking the time.

The only problem I saw when trying it on my shield was that a couple UI elements are missing: https://drive.google.com/file/d/1xn1lLTedwGUuH8xBbJrphcSriuvrnmCq/view?usp=sharing

Other than that I really like this!

abrenoch commented 6 years ago

One more thing I noticed: If you toggle the grabber on & off a few times rapidly, the toast message will stick around for a hilariously long time (I think 20 second x the number of toggles). Is there maybe a way to prevent creating a new toast if one is already displayed & dismiss it when the app loses focus?

ninovanhooff commented 6 years ago

Thanks for the feedback! The ui elements thing is super weird. I'll look into both issues. A simple solution for the toast might be to not make it a toast at all and just have a text view at the bottom screen that is always showing when the grabber is turned on. Might be less 'nagging' to ppl who have used the app for a few times already

ninovanhooff commented 6 years ago

Could not reproduce the assets issue. Im also using a shield (2015 16GB).

I tried a debug build because I don't have the signing key for a release build. Android Studio: build variants panel in the lower left.

What might help:

The icons show for me, both when turned on and turned off

Do the buttons work for you, event though you can't see them?

ninovanhooff commented 6 years ago

@abrenoch, could you try the above for me?

abrenoch commented 6 years ago

Will give this a try when I get home tonight!

abrenoch commented 6 years ago

Okay got a little more time to fiddle with it! The steps above didn't help unfortunately, but I think I did find what was going on.

When I was in the layout view it was showing a problem loading the constraintlayout element, so I just clicked the 'fix' button provided and the layout previewed correctly and it ran correctly on the shield.

I tried to reproduce what happened (so I could actually figure out what that fix button was doing), but when I loaded up the code from your branch everything worked fine this time... So I probably messed up something when switching between the projects!

Anyway, I dig it! We can merge the PR now, or if you wanted to fiddle with the notification at all could wait for that. Your call!

ninovanhooff commented 6 years ago

Go ahead and merge it, I'll do the notification after the scanner is finished.

On Wed, 30 May 2018, 01:31 Dave Anderson, notifications@github.com wrote:

Okay got a little more time to fiddle with it! The steps above didn't help unfortunately, but I think I did find what was going on.

When I was in the layout view it was showing a problem loading the constraintlayout element, so I just clicked the 'fix' button provided and the layout previewed correctly and it ran correctly on the shield.

I tried to reproduce what happened (so I could actually figure out what that fix button was doing), but when I loaded up the code from your branch everything worked fine this time... So I probably messed up something when switching between the projects!

Anyway, I dig it! We can merge the PR now, or if you wanted to fiddle with the notification at all could wait for that. Your call!

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/abrenoch/hyperion-android-grabber/pull/36#issuecomment-392981090, or mute the thread https://github.com/notifications/unsubscribe-auth/AJ3xn1tcPfPeNey8DuQFvOea1TMMWoTdks5t3dplgaJpZM4UPQ8j .