search

abrenoch / hyperion-android-grabber

Screen grabber for hyperion
MIT License
194 stars 33 forks source link

Bug/image pad fix #60

Closed abrenoch closed 6 years ago

abrenoch commented 6 years ago

This should fix the black image padding we had discussed on slack. Fixes #59 and I'm fairly certain this also solves #30.

This contains no actual image quality improvements (honestly could potentially make image quality worse), however it does fix the aspect ration not being exact. Image quality improvements will be a separate PR.

abrenoch commented 6 years ago

@ninovanhooff sure, you thinking I should just rename TARGET_BIT_RATE to something else? I could call it something like IMAGE_PACKET_SIZE, unless maybe you have something better suited in mind? I have a branch put together for the image quality adjustments where I renamed it MINIMUM_BIT_RATE (which is more applicable to how it is being used there), but we can certainly call it MINIMUM_IMAGE_PACKET_SIZE or something like that. I'm open to idea.

And for second part - do you just mean adding some comments in there? I am terrible about that 😆

abrenoch commented 6 years ago

Hey @ninovanhooff, for a revised version could you reference this commit in a separate branch: https://github.com/abrenoch/hyperion-android-grabber/commit/307292c133f65fb8fe226bab788f0256fb0edd16

A lot of the code this PR added/modified I wound up moving anyway, so I applied the changes there instead. Would just save me some copy/pasting!

abrenoch commented 6 years ago

I think when I merged from master some changes got lost, just fixed them!