search

abrenoch / hyperion-android-grabber

Screen grabber for hyperion
MIT License
194 stars 33 forks source link

German Language #72

Closed Paulchen-Panther closed 6 years ago

Paulchen-Panther commented 6 years ago

I started with the german translation. I hope it's fine if the app is multilingual. :-)

abrenoch commented 6 years ago

Fantastic initiative!

I had setup a lokalise project for this, but had not really shared it with anyone yet:

https://lokalise.co/project/525766625ab29593ebff76.47758466/?view=multi

Once we get this PR merged I'll update that with your translations (I had a friend helping me with Spanish a while ago), then hopefully we can get even more language support added in!

Paulchen-Panther commented 6 years ago

screenshot_20180721_165536

abrenoch commented 6 years ago

Whoops, forgot to add you! Will do that shortly :)

abrenoch commented 6 years ago

Just got that invite sent!

I'll take your word that the German changes are good - not like I would be able to tell anyway haha 😄

abrenoch commented 6 years ago

The only potential issue I see from using lokalise is that there doesn't really appear to be a way to separate the string files into their respective versions for this project (common/mobile/tv).

Not a huge problem, but something to think about. We could probably just merge all the strings into the common directory instead of being split-up!

abrenoch commented 6 years ago

Looks like we can use lokalise without needing to change the way the string files are structured. I just gave it access to this github (the translations branch) and it was able to import everything & maintain the folder structure as well. I also added the translatable=false attribute to the respective values, so we won't need to worry about those. It can also create PRs with updated translations which is pretty neat.

Already got a few more users signed up to add their translations!