search

abrenoch / hyperion-android-grabber

Screen grabber for hyperion
MIT License
194 stars 33 forks source link

Bug/grabber status #77

Closed abrenoch closed 6 years ago

abrenoch commented 6 years ago

Fixes the issue of the grabber status broadcast being sent before it has finished initializing

abrenoch commented 6 years ago

If you try toggling on/off a few times does it eventually turn them off correctly? I've seen this too, but I think the problem is unrelated to these changes.

In the average color PR there is a fix for that behavior: a3dfb2aecb9534054ba20e2322b9ee5387f5cd9a

It does leverage a sleep again to try to address the issue, but maybe there is a better way to delay that thread/runnable. Implementing a delay there does seem to resolve the issue. I've really been trying to figure out why, but have been left scratching my head.

abrenoch commented 6 years ago

Interesting observation with the LED count - that would also explain why the average color behavior seemed more likely to exhibit that problem!

Thanks for reviewing!