abrensch / brouter

configurable OSM offline router with elevation awareness, Java + Android
MIT License
501 stars 119 forks source link

Static code analysis using PMD #483

Closed zod closed 1 year ago

zod commented 1 year ago

Opening files with IntelliJ IDEA shows a lot of warnings for our code. This is distracting and makes it hard to see new warnings being added.

PMD and the gradle plugin allow automatic code checks during build (and CI) to prevent new violations from being added.

I've enabled the quickstart ruleset and initially disabled all rules which are currently violated. Re-enabled (and fixed) rules are:

Each rule is a single commit and can be removed I it's deemed to strict.

afischerdev commented 1 year ago

Fine helper. But before we merge this please merge all pending PRs that have no conflicts.

zod commented 1 year ago

I'm not sure why the other PRs are a prerequisite to this PR but I've either merged, commented or closes those PRs.

If this PR is merged those PRs that are still open should merge the master to get the ability to run all checks locally instead of getting feedback just from the CI build.