abrensch / brouter

configurable OSM offline router with elevation awareness, Java + Android
MIT License
510 stars 122 forks source link

Include street names in rd5 files to make voice guidance better in OsmAnd #55

Open RURon opened 8 years ago

RURon commented 8 years ago

Hello, wonderful piece of software! So far I seem to have found a way to actually use a software for road bike routing!

Back to topic. I use OsmAnd and use it for voice guidance most of the time. This would be so much better, if the street names were also spoken. I read that this is due to missing road names in the rd5 database. Is there any chance that we might have a db that includes those, preferably as 2nd choice so that everyone who does not need them can save the space? Best regards and greetings from Düsseldorf! Rodja A.

usrusr commented 5 years ago

In addition to better guidance output, this could also be the basis for a future extension to the cost model that offers an alternative to the existing turncost rules that is not based on curvature but on identity.

Currently, brouter tends to select undesirable shortcuts when there is a "direttissima" alternative to a gentle switchback climb or descent and (as far as I understand the code) no amount of turn cost can change that. A cost rule for road identity change could help alleviate that, but as long as the graph does not contain an approximation of identity (uniquity is not required, names would be fine) any experimentations towards that goal would be too big of a changeset.

Other use cases for "identity turncost" would be routing for group rides (where ease of navigation is a primary concern as every missed turn is a crash hazard and any ambiguity during long climbs or descents is problematic) and perhaps also whatever was the root goal behind issue #77 (negative turn cost).

0709wiwiwi commented 2 years ago

The following may sound rude, but don't consider it so pse. Y 2022. No street name support? Is this because it is not technically possible or is there a lack of motivation (trigger) to develop and offer it?

https://forum.kurviger.de/t/no-street-names-in-android-app-navigation-brouter/5086/3?

By the Kurviger menu freely set:

"Record street names in rd5 files to make navigation even more nice in any navigation app that uses the Brouter engine (app)"

poutnikl commented 2 years ago

@0709wiwiwi Another topic level is API(application programming interface) support for the names. As, the preferred method of LocusMap-BRouter communication is API.

But if street names were implemented in RD5 and if the support was implemented in LocusMap Gold, which has its own BRouter integrated......... As LocusMap gold uses AFAIK its own RD5 generation and deployment, I guess it could implement street names into its own RD5 files. But, it would be lot of work and the best if coordinated with BRouter development.

0709wiwiwi commented 2 years ago

@poutnikl Correct Libor and agreed. And above all, of course, it is desirable that uniformity is maintained in terms of (rd5). Since GH routing is no longer available offline, the only solution left is the offline BRouter engine. I personally do not want the street names in the TTS, but in the display I sure do appreciate it.

zod commented 2 years ago

As you already discovered the segment data (rd5) doesn't contain street names by design (https://github.com/abrensch/brouter/issues/39#issuecomment-119665274).

BRouter was mostly used for bike routing where lots of routes are in the woods where street names aren't useful. I think no one really saw the need for it. If you want to add street names to the segment data you should consider

@poutnikl I don't think the API will change if the data contains street names. The resulting voice hints would just be different.

0709wiwiwi commented 2 years ago

Hi @zod

Trigger for the updated reques is by Kurviger forum discussion. https://t.ly/OLk4-

When nobody asks the Brouter github devs, nothing will come. So here it is...... "He who does not dare does not win ;-)

poutnikl commented 2 years ago

OTOH, if street names are wanted, there is several available free car/motorbike navigations, both online and offline, already doing a good job here.

Why to come to Brouter because it is different and then making it like the same? Should not Brouter rather focus on areas where it is unique than trying to replicate what others are already doing well?

E.g. there could be useful more contribution in pedestrian scenarios. Shortest-like route is rarely ideal and nobody(AFAIK) but me tried to make some pedestrian profiles. E.g for optimal routes in urban/city areas my profiles are not particularly tailored for.

Or deeper involving existing OSM info other navigations do not consider, like various conditional restrictions. Or POIs irrelevant to navigation itself, but good to have if passing by.

0709wiwiwi commented 2 years ago

there is several available free car/motorbike navigations, both online and offline, already doing a good job here.

Offline routing service offer & completely free to use except the BRouter ? An example or a hint "how to" pse ? Offline routing yes, but not free: https://play.google.com/store/apps/details?id=com.generalmagic.magicearth&hl=en

nrenner commented 2 years ago

[offtopic]

GH offline solution is lost

Do you have a link for more info on that?

devemux86 commented 2 years ago

Do you have a link for more info on that?

https://github.com/graphhopper/graphhopper/issues/1940

GraphHopper does not work with Android scoped storage, which uses streams and not files.

poutnikl commented 2 years ago

@0709wiwiwi You have made me unsure, but Mapsfactor navigator and MagicEarth are offline and free of charge, as ad supported (ads in former, not sure about the latter) . But that is small price for the service. Both explicitly checked for available offline navigation (i.e. not just offline maps). And there is still free version of OsmAnd, where limited map downloads can be overcome by manual updates.

0709wiwiwi commented 2 years ago

@poutnikl Of course I know these (nice) apps. But Locus nor Kurviger can use the offline routing data nor engine. Neither Locus nor Kurviger can even use the OSMAND routable maps due to the different license nature.
At least, this has so been reported years ago by the Locus developer. So only the Brouter remains. By the way, street names will not change the existing function for cyclists. It can only become a bit more beautiful. Cycling in forests? If only it were so, we hardly have any forests here, finding quiet country roads is already a challenge. Our cycle junction system makes a best attempt, but even then it is still a bit of a disappointment in terms of traffic mix.

poutnikl commented 2 years ago

I have thought it was obvious they cannot use it - I was taking the goal as the priority not the tool. :-)

0709wiwiwi commented 2 years ago

[offtopic]

GH offline solution is lost

Do you have a link for more info on that?

An update on that message is necessary. A solution has been found by the Cruiser app dev to again offer the GH offline routing engine inc the streetnames.

devemux86 commented 2 years ago

This of course does not change the original request by the BRouter.

Indeed, it would be nice if BRouter could provide more details in the route responses: