search

abrensch / brouter

configurable OSM offline router with elevation awareness, Java + Android
MIT License
490 stars 118 forks source link

Download view in portait #551

Open afischerdev opened 1 year ago

afischerdev commented 1 year ago

Is it possible that BInstallerActivity not declared as forced landscape in BRouter AndroidManifest.xml ?

It is a bit annoying to have to change orientation to download BRouter files. Doesn't the map work with portrait orientation like all other map apps?

abrensch commented 1 year ago

If you do that without being prepared for the hard way of really doing responsive Design, then this will Just Produce Bug Reports..

zod commented 1 year ago

The map view would work in portait but android recreates the view during after rotation and I'm not sure if we would recreate all required information.

afischerdev commented 1 year ago

We will see. It was just a user request that I didn't want to ignore

devemux86 commented 1 year ago

android recreates the view during after rotation

This can be avoided with:

<activity
    android:name=".BInstallerActivity"
    android:configChanges="keyboard|keyboardHidden|navigation|orientation|screenLayout|screenSize|smallestScreenSize|uiMode"
    android:exported="true"
    android:launchMode="singleTask" />

The map is rotated without destroying the activity, example AndroidManifest.xml.