search

abrensch / brouter

configurable OSM offline router with elevation awareness, Java + Android
MIT License
490 stars 118 forks source link

Cleanup hgt reader #553

Closed zod closed 1 year ago

zod commented 1 year ago

It seems like #548 was merged in a hurry without a proper cleanup.

This PR still lacks handling of 1 arc second file merging into .bef.

afischerdev commented 1 year ago

This PR still lacks handling of 1 arc second file merging into .bef.

I didn't get this run with 3arc as well. What is the special naming on the conveter? Is this 'bef' format still needed?

zod commented 1 year ago

I think the idea is to replace the CSI CGIAR SRTM files with lidar sources, therefore the first argument is the filename of srtm file (doesn't need to exist, just to get lon/lat).

I've tested it using

java -cp brouter-1.6.3/brouter-1.6.3-all.jar btools.mapcreator.ConvertLidarTile srtm_38_03.zip sonny/3asec

and it reads N44E004.zip ... N50E010.zip from sonny/3asec folder and creates srtm_38_03.bef

afischerdev commented 1 year ago

@zod Yes, I already did ...ConvertLidarTile srtm_38_03.zip .... But I did it with my iceland.pbf and picked out the bef names from output. Generated the bef files - small change of the e/w format logic only -, generated Iceland again. No results for elevation on route generation. And only three of the bef files are read - protocol says. I think there are more problems in code. But I'll stop investigation for now.. HGT file import works.