search

abrensch / brouter

configurable OSM offline router with elevation awareness, Java + Android
MIT License
494 stars 118 forks source link

"No right turn on red" relation is wrongly interpreted as a prohibited turn #572

Closed tensleepslav25 closed 11 months ago

tensleepslav25 commented 1 year ago

A right turn from Cedar Street onto Worcester Street with a "no turn on red" sign (as seen in route link) is legal, however one must wait until the light turns green. I propose that restriction=no_right_turn_on_red and restriction=no_left_turn_on_red tags apply a standard traffic signal penalty, such as if the route were to continue straight.

Route link Relation link

Edit: in the meantime, is there any way to customize the car-eco profile so that the above tags are simply ignored in terms of routing?

abrensch commented 1 year ago

Hi tensleepslav25,

ja the preprocessor just looks for "only" and "no" prefixes from the restriction tag.

There seem to be competing approaches on how to map "on_red" restrictions: https://wiki.openstreetmap.org/wiki/No_turn_on_red

Sure I can filter out the "on_red" restrictions during pre-processing.

But there's no way to do it on the profile-level.

tensleepslav25 commented 1 year ago

Thanks for the reply.

Filtering out "on_red" in pre-processing seems like the most sensible solution given the lack of consensus on tagging.

quaelnix commented 1 year ago

The example mentioned in post #1 does not work for some reason. Here is one that does:

tensleepslav25 commented 1 year ago

Ah, I removed the relation from the original example as that turn is one I frequently use for routing. Thanks for finding another example and sorry for the confusion.

quaelnix commented 1 year ago

What really catched me off guard is that you "removed the restriction" by removing the via member. ;-)

Pengor commented 11 months ago

Hi, looks like this was fixed in 1a2bb19 and was included in version 1.7.1? Should this issue be closed?

I happened upon this because this (former) limitation is mentioned in a couple of places on the OSM wiki: https://wiki.openstreetmap.org/wiki/No_turn_on_red https://wiki.openstreetmap.org/wiki/Tag:restriction%3Dno_right_turn_on_red I'm happy to update those if the issue is indeed resolved.

quaelnix commented 11 months ago

Yes, this problem has been fixed. Thanks for the reminder!

PS: For some reason brouter.de is still running an older version of BRouter that does not yet include this fix.